Rene Nochebuena
bfec1761d0
Introduces code.nochebuena.dev/einherjar/smtp — the email delivery starter for the Einherjar framework. New module with no micro-lib counterpart. Pure stdlib — no external dependencies beyond contracts and core. Interfaces (CT-6: one TypeSpec per file): - Sender — Send(ctx context.Context, msg Message) error - Component — lifecycle.Component + observability.Checkable + Sender - Message — To, CC, BCC, ReplyTo, Subject, Body, ContentType, Attachments - Attachment — Name, ContentType string; Data io.Reader (consumed once on Send) - Template — wraps html/template for email rendering Implementation: - New(logger, cfg) Component — returns noopClient when cfg.Host is empty; SMTP absence must never block a transaction (e.g. account creation) - noopClient: all lifecycle and Send methods return nil; Send logs Warn; Priority LevelDegraded; Name "smtp" - smtpClient: OnInit/OnStart/OnStop are no-ops (stateless stdlib client); HealthCheck: TCP dial to Host:Port; Priority LevelDegraded - Send: buildRawMessage → netsmtp.SendMail; BCC passed in SMTP envelope (RCPT TO) but never written to message headers (RFC 5321/5322 compliance) - buildRawMessage: plain message without attachments; multipart/mixed with quoted-printable body + base64 attachments when Attachments non-empty; multipart.NewWriter created first to obtain boundary before headers are written - ParseFS(fsys, patterns...) (*Template, error) — wraps html/template.ParseFS - Template.Render(name, data) (string, error) — executes named template - net/smtp aliased as netsmtp to avoid package-name collision in package smtp Config (EINHERJAR_SMTP_* env vars): Host, Port(587), User, Password, From - Component interface embeds observability.Identifiable; identifiable.go implements ModulePath and ModuleVersion on both smtpClient and noopClient via runtime/debug.ReadBuildInfo() — prints in launcher banner
71 lines
2.3 KiB
Markdown
71 lines
2.3 KiB
Markdown
## Summary
|
|
|
|
<!-- One or two sentences: what does this PR do and why? -->
|
|
|
|
---
|
|
|
|
## Type of change
|
|
|
|
- [ ] Bug fix — non-breaking change that resolves an issue
|
|
- [ ] New feature — non-breaking addition of functionality
|
|
- [ ] Breaking change — alters existing behavior or public API
|
|
- [ ] Documentation update
|
|
- [ ] Refactor — no functional change, no new API surface
|
|
- [ ] Test improvement
|
|
|
|
---
|
|
|
|
## Description
|
|
|
|
<!--
|
|
Provide enough context for a reviewer who was not in the room:
|
|
- What problem does this solve?
|
|
- What approach did you choose, and why?
|
|
- Were there alternatives you considered and rejected?
|
|
- Any known limitations or follow-up work?
|
|
-->
|
|
|
|
---
|
|
|
|
## Testing
|
|
|
|
- [ ] I added or updated tests that cover my changes
|
|
- [ ] All tests pass locally — `go test ./...`
|
|
- [ ] No formatting issues — `gofmt -l .` produces no output
|
|
- [ ] No vet warnings — `go vet ./...` is clean
|
|
|
|
---
|
|
|
|
## Checklist
|
|
|
|
- [ ] At most one exported type per non-test `.go` file (CT-6)
|
|
- [ ] No new external dependencies added without prior discussion in an issue
|
|
- [ ] Public API changes are reflected in `CHANGELOG.md`
|
|
- [ ] Breaking changes include a migration note in the PR description above
|
|
|
|
---
|
|
|
|
## Contributor License Agreement
|
|
|
|
> **This PR will not be merged until the CLA comment is present.**
|
|
|
|
Before a Maintainer reviews your code, you must post the following text **as a comment on this PR** — not here in the description. PR description checkboxes can be silently toggled by anyone; a comment is a timestamped, author-attributed record that cannot be quietly removed.
|
|
|
|
**Copy and post this exact text as a PR comment:**
|
|
|
|
---
|
|
|
|
> I have read the Einherjar Contributor License Agreement (CLA.md) and I agree to all its terms.
|
|
> I confirm this Contribution is my original work. I grant the Maintainers the rights described
|
|
> therein, including the right to relicense, and I retain ownership of my copyright.
|
|
> This agreement covers all future Contributions I submit to any Einherjar repository under
|
|
> this account.
|
|
|
|
---
|
|
|
|
First time contributing? Read [CLA.md](../CLA.md) for the full agreement before posting the comment.
|
|
|
|
If you are contributing on behalf of a company, an authorized representative of that company must post the comment.
|
|
|
|
<!-- Thank you for contributing to Einherjar. For those who come after. -->
|