feat(mcp): check_env struct-level granularity via composes selectors #4

2026-08-07T19:39:01-06:00

Rene Nochebuena commented

2026-08-07 19:39:01 -06:00

Summary

Give check_env struct-level granularity. It could only be told which modules an app composes, so it couldn't flag a var that lives on one struct of a multi-struct module — e.g. EINHERJAR_SERVER_CORS_ORIGINS is on web.Config, and an app that composes web/server.Config never reads it, yet modules: ["web"] treated it as composed. Adds a composes input taking exact module/subpackage/Struct selectors.

Type of change

New feature — non-breaking addition (new optional input)
Breaking change

Description

composes input on check_env: struct selectors like web/server/Config, db-postgres/Config, core/logz/Config. Two-segment module/Struct targets a module-root config.
not-composed now reasons over the union of composed vars (from modules via envspec.ForModule and from composes via envspec.FindStruct), instead of a module set. This is what lets it catch struct-level dead vars.
Backward compatible: modules still works and keeps its coarse behavior; composes is additive.

Version → v1.1.1.

Test plan

go build ./... and go test ./...
New test: EINHERJAR_SERVER_CORS_ORIGINS flagged not-composed with composes: ["web/server/Config"], and NOT flagged with modules: ["web"] (documents the two granularities)
New test: malformed selector (web) and non-existent struct (web/server/Nope) both error
Redeploy and exercise check_env with composes from a live MCP client

## Summary Give `check_env` struct-level granularity. It could only be told which *modules* an app composes, so it couldn't flag a var that lives on one struct of a multi-struct module — e.g. `EINHERJAR_SERVER_CORS_ORIGINS` is on `web.Config`, and an app that composes `web/server.Config` never reads it, yet `modules: ["web"]` treated it as composed. Adds a `composes` input taking exact `module/subpackage/Struct` selectors. --- ## Type of change - [x] New feature — non-breaking addition (new optional input) - [ ] Breaking change --- ## Description - **`composes` input** on `check_env`: struct selectors like `web/server/Config`, `db-postgres/Config`, `core/logz/Config`. Two-segment `module/Struct` targets a module-root config. - **`not-composed`** now reasons over the union of composed vars (from `modules` via `envspec.ForModule` and from `composes` via `envspec.FindStruct`), instead of a module set. This is what lets it catch struct-level dead vars. - Backward compatible: `modules` still works and keeps its coarse behavior; `composes` is additive. Version → v1.1.1. --- ## Test plan - [x] `go build ./...` and `go test ./...` - [x] New test: `EINHERJAR_SERVER_CORS_ORIGINS` flagged `not-composed` with `composes: ["web/server/Config"]`, and NOT flagged with `modules: ["web"]` (documents the two granularities) - [x] New test: malformed selector (`web`) and non-existent struct (`web/server/Nope`) both error - [ ] Redeploy and exercise `check_env` with `composes` from a live MCP client

Rene Nochebuena added 1 commit 2026-08-07 19:39:01 -06:00

feat(mcp): check_env struct-level granularity via composes selectors cff5a7b4c8

Patch to v1.1.1. check_env could only reason at module granularity, so a var
that lives on one struct of a multi-struct module (e.g. EINHERJAR_SERVER_CORS_ORIGINS
on web.Config, not web/server.Config) couldn't be flagged dead when the app
composes the sibling struct. Adds struct-level selectors to close that gap.

internal/tools (check_env):
- New `composes` input: exact config structs as module/subpackage/Struct selectors
  (e.g. web/server/Config, db-postgres/Config, core/logz/Config), alongside or
  instead of the coarse `modules` list.
- not-composed now reasons over the union of composed vars (from modules AND
  struct selectors), so it surfaces struct-level dead vars. Coarse modules:["web"]
  keeps the prior behavior.
- parseStructSelector helper; errors on malformed or non-existent selectors.

Tests: struct-level dead-var catch (CORS flagged with web/server/Config but not
with module web), bad-selector errors; existing calls updated to the new arg.
Version bumped to v1.1.1 (badge + serverVersion). No dependency changes.

Rene Nochebuena requested review from CoreDevelopers 2026-08-07 19:39:02 -06:00

Rene Nochebuena requested review from Agents 2026-08-07 19:39:02 -06:00

Rene Nochebuena merged commit 81233311d9 into main

2026-08-07 19:39:07 -06:00

Rene Nochebuena deleted branch release/v1.1.1

2026-08-07 19:39:07 -06:00

Rene Nochebuena referenced this issue from a commit

2026-08-07 19:39:08 -06:00

feat(mcp): check_env struct-level granularity via composes selectors (#4)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: einherjar/mcp#4