Rene Nochebuena
caa397591e
Introduces code.nochebuena.dev/einherjar/httpclient — the outbound HTTP client starter for the Einherjar framework. Absorbs the httpclient package from micro-lib, replacing fmt.Errorf wrapping with core/xerrors and adding generic JSON helpers. Interfaces: - Provider — Do(req *http.Request) (*http.Response, error) Implementation: - New(logger, cfg) Provider — configures net.Dialer + retry + circuit breaker - NewWithDefaults(logger) Provider — convenience constructor with default config - Retry: avast/retry-go; configurable MaxRetries and RetryDelay; retries on network errors and 5xx responses; logs each retry attempt at Warn level - Circuit breaker: sony/gobreaker; opens after CBThreshold consecutive failures within CBTimeout window; returns ErrUnavailable when open - DoJSON[T](ctx, client, req) (*T, error) — executes request, decodes JSON body - DoJSONRequest[Req, Resp](ctx, client, method, rawURL, body) (*Resp, error) — marshals body, builds request, executes, decodes response - MapStatusToError(code, msg) error — maps HTTP status codes to xerrors values Config (EINHERJAR_HTTP_* env vars): Name(http), Timeout(30s), DialTimeout(5s), MaxRetries(3), RetryDelay(1s), CBThreshold(10), CBTimeout(1m) - identifiable.go: package-level Module variable (observability.Identifiable) for version identification — httpclient is a stateless provider; not registered with the launcher
2.3 KiB
Summary
Type of change
- Bug fix — non-breaking change that resolves an issue
- New feature — non-breaking addition of functionality
- Breaking change — alters existing behavior or public API
- Documentation update
- Refactor — no functional change, no new API surface
- Test improvement
Description
Testing
- I added or updated tests that cover my changes
- All tests pass locally —
go test ./... - No formatting issues —
gofmt -l .produces no output - No vet warnings —
go vet ./...is clean
Checklist
- At most one exported type per non-test
.gofile (CT-6) - No new external dependencies added without prior discussion in an issue
- Public API changes are reflected in
CHANGELOG.md - Breaking changes include a migration note in the PR description above
Contributor License Agreement
This PR will not be merged until the CLA comment is present.
Before a Maintainer reviews your code, you must post the following text as a comment on this PR — not here in the description. PR description checkboxes can be silently toggled by anyone; a comment is a timestamped, author-attributed record that cannot be quietly removed.
Copy and post this exact text as a PR comment:
I have read the Einherjar Contributor License Agreement (CLA.md) and I agree to all its terms. I confirm this Contribution is my original work. I grant the Maintainers the rights described therein, including the right to relicense, and I retain ownership of my copyright. This agreement covers all future Contributions I submit to any Einherjar repository under this account.
First time contributing? Read CLA.md for the full agreement before posting the comment.
If you are contributing on behalf of a company, an authorized representative of that company must post the comment.