Rene Nochebuena
d64fd5403d
Introduces code.nochebuena.dev/einherjar/db-mysql — the MySQL database starter for the Einherjar framework. Absorbs the mysql package from micro-lib using the go-sql-driver/mysql driver, replacing fmt.Errorf wrapping with core/xerrors. Interfaces (CT-6: one TypeSpec per file): - Executor — ExecContext, QueryContext, QueryRowContext (database/sql types) - Tx — Executor + Commit(), Rollback() — no ctx; honest database/sql contract - Provider — GetExecutor, Begin, BeginTx, Ping, HandleError - Component — lifecycle.Component + observability.Checkable + Provider + Stats() - UnitOfWork — Do(ctx, fn) Implementation: - New(logger, cfg) Component — pool not created until OnInit - OnInit: sql.Open + SetMaxOpenConns/SetMaxIdleConns/SetConnMaxLifetime/SetConnMaxIdleTime - OnStart: Ping with 5s timeout; logs "mysql: connected" - OnStop: db.Close(); logs "mysql: closing pool" - GetExecutor: returns active Tx from context (ctxTxKey) or *sql.DB; explicit nil return when db uninitialized to avoid typed-nil interface pitfall - Begin/BeginTx: wraps db.BeginTx(*sql.TxOptions); wrapped in xerrors on error - HealthCheck: delegates to Ping; Priority LevelCritical - Stats() sql.DBStats — zero value when pool uninitialized - NewUnitOfWork(logger, provider) UnitOfWork — Begin+inject+commit/rollback; no write mutex (MySQL is a server DB with internal concurrency control) - HandleError: 1062→ErrAlreadyExists, 1216/1217/1451/1452→ErrInvalidInput, sql.ErrNoRows→ErrNotFound, all others→ErrInternal - Driver imported as mysqldrv alias in errors.go to avoid package-name collision; registered via blank import in new.go Config (EINHERJAR_MYSQL_* env vars): Host, Port(3306), User, Password, Name, MaxConns(5), MinConns(2), MaxConnLifetime(1h), MaxConnIdleTime(30m), Charset(utf8mb4), Loc(UTC), ParseTime(true) - Component interface embeds observability.Identifiable; identifiable.go implements ModulePath and ModuleVersion via runtime/debug.ReadBuildInfo() — prints in launcher banner
2.3 KiB
Summary
Type of change
- Bug fix — non-breaking change that resolves an issue
- New feature — non-breaking addition of functionality
- Breaking change — alters existing behavior or public API
- Documentation update
- Refactor — no functional change, no new API surface
- Test improvement
Description
Testing
- I added or updated tests that cover my changes
- All tests pass locally —
go test ./... - No formatting issues —
gofmt -l .produces no output - No vet warnings —
go vet ./...is clean
Checklist
- At most one exported type per non-test
.gofile (CT-6) - No new external dependencies added without prior discussion in an issue
- Public API changes are reflected in
CHANGELOG.md - Breaking changes include a migration note in the PR description above
Contributor License Agreement
This PR will not be merged until the CLA comment is present.
Before a Maintainer reviews your code, you must post the following text as a comment on this PR — not here in the description. PR description checkboxes can be silently toggled by anyone; a comment is a timestamped, author-attributed record that cannot be quietly removed.
Copy and post this exact text as a PR comment:
I have read the Einherjar Contributor License Agreement (CLA.md) and I agree to all its terms. I confirm this Contribution is my original work. I grant the Maintainers the rights described therein, including the right to relicense, and I retain ownership of my copyright. This agreement covers all future Contributions I submit to any Einherjar repository under this account.
First time contributing? Read CLA.md for the full agreement before posting the comment.
If you are contributing on behalf of a company, an authorized representative of that company must post the comment.