The package-doc examples showed a fictional launcher.Register / health.Register
API (and launcher.Append as a package func). Corrected to the real wiring:
lc.Append + web/health.NewHandler(...).ServeHTTP.
Documentation-only. No code, API, or dependency changes; version stays v1.1.0
(the v1.1.0 tag is moved to include this fix). Verified by compiling the
corrected pattern against the real API.
Reviewed-on: #2
Co-authored-by: Rene Nochebuena Guerrero <rene@nochebuena.dev>
Co-committed-by: Rene Nochebuena Guerrero <rene@nochebuena.dev>
Patch of the coordinated framework release: einherjar modules move to v1.1.0
in lockstep, so db-mysql is bumped alongside the rest.
- go.mod: contracts, core -> v1.1.0 (via go get + go mod tidy)
No code or API changes. ModuleVersion() reports v1.1.0 automatically from
build info once tagged. Badge bumped to v1.1.0.
Reviewed-on: #1
Co-authored-by: Rene Nochebuena Guerrero <rene@nochebuena.dev>
Co-committed-by: Rene Nochebuena Guerrero <rene@nochebuena.dev>
Introduces code.nochebuena.dev/einherjar/db-mysql — the MySQL database starter
for the Einherjar framework. Absorbs the mysql package from micro-lib using the
go-sql-driver/mysql driver, replacing fmt.Errorf wrapping with core/xerrors.
Interfaces (CT-6: one TypeSpec per file):
- Executor — ExecContext, QueryContext, QueryRowContext (database/sql types)
- Tx — Executor + Commit(), Rollback() — no ctx; honest database/sql contract
- Provider — GetExecutor, Begin, BeginTx, Ping, HandleError
- Component — lifecycle.Component + observability.Checkable + Provider + Stats()
- UnitOfWork — Do(ctx, fn)
Implementation:
- New(logger, cfg) Component — pool not created until OnInit
- OnInit: sql.Open + SetMaxOpenConns/SetMaxIdleConns/SetConnMaxLifetime/SetConnMaxIdleTime
- OnStart: Ping with 5s timeout; logs "mysql: connected"
- OnStop: db.Close(); logs "mysql: closing pool"
- GetExecutor: returns active Tx from context (ctxTxKey) or *sql.DB; explicit
nil return when db uninitialized to avoid typed-nil interface pitfall
- Begin/BeginTx: wraps db.BeginTx(*sql.TxOptions); wrapped in xerrors on error
- HealthCheck: delegates to Ping; Priority LevelCritical
- Stats() sql.DBStats — zero value when pool uninitialized
- NewUnitOfWork(logger, provider) UnitOfWork — Begin+inject+commit/rollback;
no write mutex (MySQL is a server DB with internal concurrency control)
- HandleError: 1062→ErrAlreadyExists, 1216/1217/1451/1452→ErrInvalidInput,
sql.ErrNoRows→ErrNotFound, all others→ErrInternal
- Driver imported as mysqldrv alias in errors.go to avoid package-name collision;
registered via blank import in new.go
Config (EINHERJAR_MYSQL_* env vars):
Host, Port(3306), User, Password, Name,
MaxConns(5), MinConns(2), MaxConnLifetime(1h), MaxConnIdleTime(30m),
Charset(utf8mb4), Loc(UTC), ParseTime(true)
- Component interface embeds observability.Identifiable; identifiable.go implements
ModulePath and ModuleVersion via runtime/debug.ReadBuildInfo() — prints in launcher banner
Rene Nochebuena
