go/xerrors
2
0
Fork 0
Code Issues Pull Requests Packages Releases 4 Activity

fix(xerrors): rename MarshalJSON field platformCode → platform_code #3

Merged
Rene Nochebuena merged 1 commits from fix/platform-code-json-tag into main 2026-05-21 19:30:11 -06:00
Conversation 0 Commits 1 Files Changed 4 +17 -7
Rene Nochebuena commented 2026-05-21 19:30:01 -06:00
Owner
Copy Link

Summary

  • Corrects MarshalJSON JSON tag from "platformCode" to "platform_code" to match
    the OpenAPI spec snake_case convention for error response fields
  • Updates all test assertions to expect "platform_code"
  • Adds PR.md to .gitignore

Test plan

  • go test ./... passes
  • JSON output of *Err contains "platform_code", not "platformCode"
  • "platform_code" is omitted when empty (omitempty still applies)
## Summary - Corrects `MarshalJSON` JSON tag from `"platformCode"` to `"platform_code"` to match the OpenAPI spec snake_case convention for error response fields - Updates all test assertions to expect `"platform_code"` - Adds `PR.md` to `.gitignore` ## Test plan - [x] `go test ./...` passes - [x] JSON output of `*Err` contains `"platform_code"`, not `"platformCode"` - [x] `"platform_code"` is omitted when empty (omitempty still applies)
Rene Nochebuena added 1 commit 2026-05-21 19:30:01 -06:00
fix(xerrors): rename MarshalJSON field platformCode → platform_code e24cbadf71 
JSON tag on the anonymous struct inside MarshalJSON corrected from
`json:"platformCode,omitempty"` to `json:"platform_code,omitempty"` to
match the OpenAPI spec snake_case convention. All error responses that
serialize *Err directly now emit "platform_code" instead of "platformCode".
PR.md added to .gitignore.
Rene Nochebuena merged commit 9ce3ac8174 into main 2026-05-21 19:30:11 -06:00
Rene Nochebuena deleted branch fix/platform-code-json-tag 2026-05-21 19:30:12 -06:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claude rene Rene Nochebuena
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: go/xerrors#3
Delete Branch "fix/platform-code-json-tag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?