go/httputil
2
0
Fork 0
Code Issues Pull Requests Packages Releases 4 Activity

fix(httputil): rename error body field platformCode → platform_code #2

Merged
Rene Nochebuena merged 1 commits from fix/platform-code-error-body into main 2026-05-21 19:34:42 -06:00
Conversation 0 Commits 1 Files Changed 6 +20 -6
Rene Nochebuena commented 2026-05-21 19:34:29 -06:00
Owner
Copy Link

Summary

  • Corrects errorBody() JSON key from "platformCode" to "platform_code" to match
    the OpenAPI spec snake_case convention
  • Bumps xerrors dependency to v1.0.2 (which carries the same fix for MarshalJSON)
  • Updates all test assertions to expect "platform_code"
  • Adds PR.md to .gitignore

Test plan

  • go test ./... passes
  • HTTP error response body contains "platform_code", not "platformCode"
  • "platform_code" is absent when platform code is empty
## Summary - Corrects `errorBody()` JSON key from `"platformCode"` to `"platform_code"` to match the OpenAPI spec snake_case convention - Bumps `xerrors` dependency to v1.0.2 (which carries the same fix for `MarshalJSON`) - Updates all test assertions to expect `"platform_code"` - Adds `PR.md` to `.gitignore` ## Test plan - [x] `go test ./...` passes - [x] HTTP error response body contains `"platform_code"`, not `"platformCode"` - [x] `"platform_code"` is absent when platform code is empty
Rene Nochebuena added 1 commit 2026-05-21 19:34:29 -06:00
fix(httputil): rename error body field platformCode → platform_code ccfa3d1527 
errorBody() map key corrected from "platformCode" to "platform_code" to
match the OpenAPI spec snake_case convention. All HTTP error responses
produced by Error(w, err) now emit "platform_code" in the JSON body.
PR.md added to .gitignore.
Depends on xerrors v1.0.2 (go.mod bumped in follow-up commit after xerrors tag).
Rene Nochebuena requested review from CoreDevelopers 2026-05-21 19:34:29 -06:00
Rene Nochebuena requested review from Agents 2026-05-21 19:34:29 -06:00
Rene Nochebuena merged commit b794bf668e into main 2026-05-21 19:34:42 -06:00
Rene Nochebuena deleted branch fix/platform-code-error-body 2026-05-21 19:34:42 -06:00
Sign in to join this conversation.
Reviewers
No Reviewers
go/CoreDevelopers
go/Agents
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
claude rene Rene Nochebuena
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: go/httputil#2
Delete Branch "fix/platform-code-error-body"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?