einherjar/spa-server
2
0
Fork 0
Code Issues Pull Requests Packages Releases 2 Activity

fix(docker): drop inherited VOLUME /srv/www that caused silent stale deploys

Browse Source 
VOLUME ["/srv/www"] created an anonymous volume that docker compose reuses across
container recreation, shadowing a freshly COPY'd SPA bundle with the previous build
— up -d --build exited 0 while serving the old bundle (and poisoned the PWA service
worker's ngsw.json). A child image cannot un-declare an inherited VOLUME, so it must
not be declared: removing it makes the COPY case deterministic and leaves the runtime
bind-mount case unaffected. Also refreshed the README FROM tag v1.0.0 -> v1.6.0.
This commit is contained in:
Rene Nochebuena
2026-08-18 17:27:04 -06:00
parent e4f3ba1882
commit bbc588d933
3 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Dockerfile
+7 -2
View File
@@ -25,7 +25,12 @@ LABEL org.opencontainers.image.base.name="alpine:3.21"
LABEL org.opencontainers.image.base.digest="$BASE_DIGEST"
LABEL dev.nochebuena.healthz="/health"
# Mount your SPA dist/ here, or COPY it in a downstream Dockerfile.
VOLUME ["/srv/www"]
# Provide your SPA build at /srv/www — COPY dist/ in a downstream Dockerfile, or
# bind-mount it at runtime (-v /path/to/dist:/srv/www). No VOLUME is declared here
# on purpose: a VOLUME at this path creates an anonymous volume that `docker compose
# up` reuses across container recreation, shadowing a freshly COPY'd bundle with the
# previous build — a silent stale deploy (worse for PWAs, whose service worker then
# caches the stale ngsw.json). A runtime bind-mount works with or without it, and a
# child image cannot un-declare an inherited VOLUME, so it must not be declared at all.
EXPOSE 8080
ENTRYPOINT ["/app/spa-server"]